smeighan / nutcracker

RGB Effects builder for Chistmas Animations
15 stars 15 forks source link

L/R Direction checkboxes in second screen of Single String not working #43

Open maffeirw opened 11 years ago

maffeirw commented 11 years ago

When I try to change the direction of any of the four segments in my HalloweenChaseToPeak effect on the EVES_NG model (or any other single string effect), the segments I change to get the lights to chase tin another direction do not have any effect when I regenerate the effect. This happens in both the generated gif and in the resulting Vixen .vir file. Also the changes do not seem to remain when I close and reopen the effect.

maffeirw commented 11 years ago

After installing and using Chrome I noticed that the direction buttons actually work and the Vixen routine generated is correct. The main problem is that the effect is not storing the L/R direction buttons that have been selected, so the effect reverts back to all right buttons selected when you go back into the effect or access the effect via Projects.

jasoveen commented 11 years ago

The direction value is getting stored in the database, just not being detected correctly when you first load an effect. The issue is on line 539 of "nutcracker/effects/f_single_strand.php". It's looking for a column name of "dir" instead of "direction". Change the line to "if($param_name=='direction')" seems to resolve the issue on my local install. (Any effects that defaulted to "right" and got generated again will have to be manually reset back to "left")

kgustafson commented 11 years ago

This error is the same as one prior.