search

smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.
https://smeijer.github.io/leaflet-geosearch/
MIT License
1.03k stars 273 forks source link

Add OpenCage Provider #158

Closed kaoru closed 5 years ago

kaoru commented 6 years ago

Add support for the OpenCage Geocoder (https://geocoder.opencagedata.com)

I followed the steps from https://github.com/smeijer/leaflet-geosearch/pull/143 so it was all fairly straightforward :grin: I tested with my personal OpenCage API key and the tests pass ok, but of course you should sign up and give it a go yourself :+1:

The only thing I wasn't sure about is that LocationIQ's PR included some changes to files in docs/dist/ - those files look automatically generated, what's the command to re-generate them? Why is there a dist and a docs/dist/?

Let me know if you have any questions. Thanks!

freyfogle commented 6 years ago

Hi, any hope of getting this merged? thanks

freyfogle commented 5 years ago

Hi, something is preventing this PR from being merged. What is it? What can we do to move it forward? Thanks for your attention, Ed

smeijer commented 5 years ago

Time, only the lack of time. See #172

freyfogle commented 5 years ago

ahh, had not seen that. Many thanks for merging, and for the project. I appreciate it