Fix for google provider test

smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.

https://smeijer.github.io/leaflet-geosearch/

MIT License

1.03k stars 273 forks source link

Fix for google provider test #208

Closed yznts closed 4 years ago

yznts commented 4 years ago

API Key is required now

add an API key from env to provider in tests
remove a test, related to fetching with API key (fetching with key by default)

yznts commented 4 years ago

@smeijer Please, can you provide a Google API Key in the Travis CI as an environment variable? Suddenly, API Key is required by Google now. Thank you very much!

smeijer commented 4 years ago

Does it require a payment (registration)?

yznts commented 4 years ago

Yes, it requires registration. As I know, Google API has free tier, up to 70000 requests. If it’s impossible, I can skip the test, depending on provided env (if api key is not provided, just skipping). In that way, we will have ability to normally build that project in CI. Please, notify me about your decision, I’ll do my best.

smeijer commented 4 years ago

Skipping the test if the key isn't provided, sounds fine for the time being.

That gives me some time to get a new api key and add it to CI.

yznts commented 4 years ago

@smeijer Hi! Is there any update on this? It's simple PR 🙂

smeijer commented 4 years ago

merged. Thanks

yznts commented 4 years ago

@smeijer Thank you very much 🙏