search

smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.
https://smeijer.github.io/leaflet-geosearch/
MIT License
1.03k stars 273 forks source link

feat: improve labels of Algolia provider by using match level #222

Closed yznts closed 4 years ago

yznts commented 4 years ago

Solution for #221

smeijer commented 4 years ago

Thanks for your pull-request @yzinets! Can you show me a before/after screenshot?

yznts commented 4 years ago

Here are old results (an example of incorrect postcode in labels)

Screenshot 2020-05-28 at 21 09 01

And new one (corrected with match level)

Screenshot 2020-05-28 at 21 08 27

To be honest, I don't really think that this solution (code) is pretty much, but it solves this issue :)

Also, I'd like to create another one issue, related to docs and development process. It was a bit hard to make a screenshot on the local instance of docs (npm run docz:dev just gives an error in my case). It would be great to make some notes in readme for contributors.

smeijer commented 4 years ago

Aaah, I see. It's really just incorrect postal codes? Thanks! I'll merge.

About the dev, I understand. I think you should just use npm run start, and not docz:dev. If that doesn't work, (because of cross dependencies between build & docs), it might be necessary to run npm run build first.

smeijer commented 4 years ago

Merged and published as leaflet-geosearch@3.0.5. Again, thanks for your contribution :+1:

smeijer commented 3 years ago

Hi @yuriizinets, I've noticed your activity on this repo, and wanted to say thanks!

I've added you as a collaborator on the project.

You might want to watch the repo to be notified when someone files an issue/PR. Please continue to contribute and make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want).

Thanks! And welcome to the team :tada:

yznts commented 3 years ago

Hi @smeijer , thank you for invite! I'm already watching this repo :) I'll help to handle some issues/tasks when will there be some free time, sometimes I have too much work. Anyway, I'll do my best!

Also, feel free to contact me via email if something is needed