smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.
https://smeijer.github.io/leaflet-geosearch/
MIT License
1.02k stars 271 forks source link

feat: add option for custom "not found message" #284

Closed patou closed 2 years ago

patou commented 3 years ago

Fix #282 Display not found message

The properties notFoundMessage isn't used in the lib. If there are 0 result and the notFountMessage is setted, display the message : image

image

In the resultList class, classNames isn't filled. Add two new properties in the classNames config :

By default, the config option notFoundMessage as the default unused value : 'Sorry, that address could not be found.', Does change it to default to empty, to keep the same behavior as now ?

patou commented 2 years ago

Is there any think I can do for the PR merged ?

smeijer commented 2 years ago

Sorry, I should have responded earlier. Can you change the default behavior to be the current situation? Even though I believe your default is better, I don't want to change the behavior for existing implementations.

patou commented 2 years ago

@smeijer I change to use not display not found message by default.