smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.
https://smeijer.github.io/leaflet-geosearch/
MIT License
1.02k stars 271 forks source link

Where (or what) is release 3.5.2? #300

Closed gjvoosten closed 2 years ago

gjvoosten commented 2 years ago

npm lists 3.5.2 as the latest release: https://www.npmjs.com/package/leaflet-geosearch/v/3.5.2 yet there is no sign of any 3.5.2 release on GitHub, and even package.json still specifies 3.5.1. Slightly suspicious… :thinking:

missinglink commented 2 years ago

FYI: there's a little known tool called npm diff which behaves similarly to git diff:

npm diff --diff leaflet-geosearch@3.5.0 --diff leaflet-geosearch@3.5.2 --diff-name-only

dist/bundle.min.js
dist/geosearch.js
dist/geosearch.module.js
dist/geosearch.umd.js
lib/SearchControl.js
package.json
dist/geosearch.js.map
dist/geosearch.module.js.map
dist/geosearch.umd.js.map
lib/SearchControl.js.map
dist/SearchControl.d.ts
lib/SearchControl.d.ts
src/SearchControl.ts
gjvoosten commented 2 years ago

That still leaves the question whence release 3.5.2 came. Not from this repository, AFAICT.

missinglink commented 2 years ago

Yeah good question, there was a Travis-CI credentials leaks recently, not saying it was that BTW.

smeijer commented 2 years ago

Sorry, I simply forgot to push the new package.json. That's done now.

3.5.2 was a quick push on top of 3.5.1, because of a mistake during the publish step. The code hasn't changed between 3.5.1 and 3.5.2, only the generated type definitions did.

gjvoosten commented 2 years ago

Thanks for the quick resolution (and reassurance), @smeijer ! Please remember to tag your relevant commit (v3.5.2).

smeijer commented 2 years ago

Done