[accessibility] Reset button is missing an accessible name and `role="button"`

smeijer / leaflet-geosearch

A geocoding/address-lookup library supporting various api providers.

https://smeijer.github.io/leaflet-geosearch/

MIT License

1.02k stars 270 forks source link

Open Malvoz opened 2 years ago

Malvoz commented 2 years ago

[ ] The reset button is missing an accessible name, it is currently announced as "times" or "multiplication" depending on the screen reader. It should have aria-label="Reset".
[ ] The reset button is a link, though it should be conveyed as a button to screen reader users, using role="button".

Potentially helpful resources:

smeijer commented 2 years ago

I'd love to accept a pull request for this.

StellarLogic commented 3 weeks ago

I would love to work on this, can you assign it to me

smeijer commented 2 weeks ago

I'm not assigning tickets. Please just submit the pull if you're feeling for it. Thanks!