search

smellyrat / drydock

Automatically exported from code.google.com/p/drydock
0 stars 0 forks source link

Standardize our board lookups and ID methods #61

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
In some places, board is defined by ID, in other places, by FOLDER

It should ALWAYS be defined by folder from the user, and then from there we
need to decide how to handle it in code

In some places (putpost) we already have the board as an id, but then when
we pass that id off to getglobalid, getglobalid is looking for a folder

Propose:  pass always as folder outside
Once we get binfo and post data, only pass around ids
if there's ANYWHERE that a PERSON sees board id, make sure it's by folder
Anywhere the code sees it, handle as id number.

Original issue reported on code.google.com by TaQS...@gmail.com on 15 Apr 2009 at 6:27

GoogleCodeExporter commented 9 years ago 
As a stopgap I moved some stuff around in MySQL-post, but honestly, by the time 
that
it gets there, it should be a number already.

I propose in thread.php and reply.php we just pass binfo['id'] instead of 
binfo['folder']

I had to change id to folder in the call to putpost in reply.php but I think we
should change it back, just to keep the code clean and reduce the need to use
getboardnumber, since we can already access that number without more db calls.

I'll put my changes back into the svn though, but this is the direction I want 
to go in.

Original comment by TaQS...@gmail.com on 15 Apr 2009 at 9:24

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/drydock/source/detail?r=127

Original comment by TaQS...@gmail.com on 15 Apr 2009 at 10:31

GoogleCodeExporter commented 9 years ago 
Tagging to 032 because I still want to resolve this

Original comment by TaQS...@gmail.com on 8 Jul 2009 at 7:32