smellyrat / drydock

Automatically exported from code.google.com/p/drydock
0 stars 0 forks source link

Should static pages be able to handle some HTML? #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
My gut says yes.  Also it should differentiate more between what title and
name mean (as in, displayed title, url name, something like that)

Original issue reported on code.google.com by TaQS...@gmail.com on 31 Aug 2009 at 6:21

GoogleCodeExporter commented 9 years ago
I thought it already did.  We're not filtering it on the template level:
http://code.google.com/p/drydock/source/browse/branches/drydock-june11-SQLITE-TE
ST-
BUILD/tpl/drydock-image/staticpage.tpl#20

We're not filtering it out in admin.php:
http://code.google.com/p/drydock/source/browse/branches/drydock-june11-SQLITE-TE
ST-
BUILD/admin.php#1111

We might be escaping it with $this->clean by accident:
http://code.google.com/p/drydock/source/browse/branches/drydock-june11-SQLITE-TE
ST-
BUILD/dbi/MySQL-mod.php#997

But yeah, it's supposed to be able to handle HTML, or at least how I envisioned 
it 
when I wrote it.

Original comment by all.sta...@gmail.com on 31 Aug 2009 at 4:32

GoogleCodeExporter commented 9 years ago
I'll mess with it, but it's not working that way right now.  I've got a bunch 
of other things i should commit and 
then package as a beta

Original comment by TaQS...@gmail.com on 31 Aug 2009 at 6:33

GoogleCodeExporter commented 9 years ago
I changed it to escape_string and it seems to save correctly now.  We should
standardize all of this stuff in 032

Original comment by TaQS...@gmail.com on 1 Sep 2009 at 4:50