smerf-3d / smerf-3d.github.io

133 stars 12 forks source link

Problem with background colour with transperant or errored pixel values: black seems a better choice #9

Closed samhodge-aiml closed 2 months ago

samhodge-aiml commented 3 months ago

See video

https://github.com/smerf-3d/smerf-3d.github.io/assets/102564797/8feaa0a6-45b6-47d2-b3d5-1c619b8e9bae

Hosted here https://smerfaimllab.s3.amazonaws.com/viewer_simple/index.html?dir=checkpoints/20240525_0720-demo/baked/sm_000&backgroundColor=000000&quality=high&combineMode=concat_and_sum&s=1245,825&vfovy=40.038544&useDistanceGrid=true

the default_exposure is set to 80 which seems better

&backgroundColour=000000 doesnt seem to make a difference

@duckworthd if you could give some feedback that would be great.

DuVogel87 commented 3 months ago

Is this a viewer problem or calculation (output) problem?

Did you check other viewers like https://playcanvas.com/supersplat/editor or https://playcanvas.com/viewer for example?

samhodge-aiml commented 3 months ago

@DuVogel87 I think you are misunderstanding how SMERF works, it is based on the java script code and the encoded triplanar views, there is no viewer that will display the data.

duckworthd commented 2 months ago

Hi @samhodge-aiml, I unfortunately don't have the cycles to comment on individual reconstructions. Feel free to toy and edit the method as you see fit. This codebase is meant to be a research proof-of-concept.

samhodge commented 2 months ago

If I figure it out I will send through a PR thanks for your contribution it is an awesome piece of work