Feature/ls24003777/setll figurative constants - Githubissues

smeup / jariko

a JAva virtual machine Rpg Interpreter written in KOtlin

Apache License 2.0

65 stars 11 forks source link

Feature/ls24003777/setll figurative constants #596

Closed dom-apuliasoft closed 2 months ago

dom-apuliasoft commented 2 months ago

Description

Add support for *START and *END as factor 1 in SETLL statements.

Changes contain:

The new AST creation rule
The StartValExpr and EndValExpr definitions
The StartValValue and EndValValue
The StartValType and EndValType (not used yet, might be useful in future)
The new SETLL rule

Related to:

LS24003777

Checklist:

[x] If this feature involves RPGLE fixes or improvements, they are well-described in the summary.
[x] There are tests for this feature.
[x] RPGLE code used for tests is easily understandable and includes comments that clarify the purpose of this feature.
[x] The code follows Kotlin conventions (run ./gradlew ktlintCheck).
[x] The code passes all tests (run ./gradlew check).
[ ] Relevant documentation is included in the docs directory.

dom-apuliasoft commented 2 months ago

@lanarimarco I updated the code with the suggestion you proposed. I also added a new method usePopulated that is a wrapper on top of the AutoCloseable that executes the DB population queries on it's own as from my experience this is a step very easy to forget and difficult to trace. Let me know if you see further margin of improvement anywhere.