smhaller / ldap-overleaf-sl

Free LDAP and OAuth2 Authentication and Authorisation for Sharelatex / Overleaf (Community Edition)
GNU Affero General Public License v3.0
74 stars 35 forks source link

add texlive path - use latest texlive #48

Closed maurerle closed 8 months ago

maurerle commented 8 months ago

This commit moves to tlmgr to install the latest texlive version. Somehow the bin of the latex install dir is not on the PATH so we add it.

An image installed from this has a size of about 6.8GB and includes all packages of a typical latex distribution

yzx9 commented 8 months ago

It looks good, although I haven't tested this code yet. There's a suggestion regarding the Dockerfile: each instruction in a Dockerfile creates a layer in the image. Therefore, I suggest minimizing additional RUN instructions. Instead, execute it before the previous RUN instruction's cleanup commands (apt-get clean && rm -rf /var/lib/apt/lists/*). This approach can significantly reduce the size of the image file.

Update: resolved

smhaller commented 8 months ago

Yes, each RUN instruction generates a new layer - for a final version in terms of size this maybe a good thing - if you are trying and testing things you might want to have more RUN instructions because you have layers were you can build and test on on top of that layer (skipping maybe a huge build process)

PS: I'll have time to test the code earliest upcoming monday - so if anyone is faster go for it :)