search

smhaller / ldap-overleaf-sl

Free LDAP and OAuth2 Authentication and Authorisation for Sharelatex / Overleaf (Community Edition)
GNU Affero General Public License v3.0
74 stars 35 forks source link

Support for automated testing #7

Open andreas-bulling opened 3 years ago

andreas-bulling commented 3 years ago

Hi,

Do you see a chance to test with/support the latest OSS Sharelatex version (2.6.1 at the moment I believe) and, in general, future latest versions? There is unfortunately no changelog for the things they implement as far as I know. And the open source version is generally put in second place behind the commercial version. But it would still be nice to be current with the small improvements in Sharelatex that they are willing to share with the community.

smhaller commented 3 years ago

Lets see if we could do some automated testing with something like https://github.com/rroemhild/docker-test-openldap .

andreas-bulling commented 3 years ago

good idea - I guess one line of tests is about whether the changes can still be applied to the updated codebase. A second is what you suggest - whether the changes functionally work with the new Sharelatex version.

smhaller commented 3 years ago

I just tried 2.6.1 on my test instance and it seems to work. I updated the repo (but i still didn't look into the CI/CD for the latest versions.. lets see maybe this weekend)

haslersn commented 3 years ago

I can confirm that 2.6.1 works; note that I used a different Dockerfile (using --build-arg BASE=docker.io/sharelatex/sharelatex:2.6.1).

wixaw commented 3 years ago

Hello I am discovering your LDAP custom. It's great, but I am afraid of the long time! If this is broken I would not want to be blocked with a old version What do you think ? It's safe ?

And I would need to tie two branches Branch1 ou=people for our users (id = cn)(all) Branch2 ou=peopleext for our partners (id = uid)(memberof=cn=xxxxxx)

It's possible ? Thanks

smhaller commented 3 years ago

2.6.1 is working. I keep this open to remind that I/we should find a way for automated testing.

For the two branches i think you can write a filter like: (|(FIRSTFILTER)(SECONDFILTER))

smhaller commented 2 years ago

3.0.1 is working.