search

smhaller / ldap-overleaf-sl

Free LDAP and OAuth2 Authentication and Authorisation for Sharelatex / Overleaf (Community Edition)
GNU Affero General Public License v3.0
74 stars 35 forks source link

More flexible approach to LDAP filter strings #9

Closed SF2311 closed 3 years ago

SF2311 commented 3 years ago

Based on the great work of @chhu in #6 this allows the use of a dedicated bind user. We took a less restricting approach for the format of the used filter strings.

smhaller commented 3 years ago

Yes, looks good - could you adapt the pull request such that it is still possible to have no ldap bind user e.g. only use your flexible approach if the environment variable for a bind user is set otherwise do it the original (direct) way.

Thank you very much for your contribution

Simon

SF2311 commented 3 years ago

I made it that the LDAP_BINDDN variable controls the authentication process. If set, the LDAP bind happens directly with the authenticating user and a fixed DN.