#37 support unescaped double quotes

smhg / gettext-parser

Parse and compile gettext po and mo files, nothing more, nothing less

MIT License

158 stars 44 forks source link

#37 support unescaped double quotes #38

Closed TimKam closed 6 years ago

TimKam commented 6 years ago

Support unescaped double quotes Closes #37 Adjusts the parser so that it only considers a double quote as closing if it's at the end of the line/end of file.

TimKam commented 6 years ago

@smhg Could you take a look? :-)

smhg commented 6 years ago

I didn't get any email from GitHub about this repo last month. I'll have a look at you issue/PR tomorrow. Thanks!

smhg commented 6 years ago

Am I missing something or are there no unescaped quotes in test/fixtures/unescaped_double_quotes.po?

TimKam commented 6 years ago

Sorry! I guess I made a mistake when updating the test file with a dedicated .po editor, will change that real quick.

smhg commented 6 years ago

As mentioned in #37: closing for now, but please reopen if appropriate.