fix: charset found was discarded due to default charset init

smhg / gettext-parser

Parse and compile gettext po and mo files, nothing more, nothing less

MIT License

158 stars 43 forks source link

fix: charset found was discarded due to default charset init #48

Closed vallo87 closed 5 years ago

smhg commented 5 years ago

Thank you for this PR! Could you add at least one test for this issue? Then we're good to merge.

vallo87 commented 5 years ago

sure, I'll get to it ASAP

AlexMost commented 5 years ago

Waiting for this PR to be merged and released - https://github.com/ttag-org/ttag-cli/issues/56

smhg commented 5 years ago

I've added a test that covers the case mentioned in #12. This PR does not seem to address those issues, but it might actually fix a different issue? I'll try to come up with a solution for #12 ASAP and then I'll be able to evaluate what needs to be done with this PR.

If however an independent issue, definitely feel free to submit a separate test case for which this solution applies.

smhg commented 5 years ago

Closing this PR as recent changes should have fixed this properly. More in #12.