search

smhg / gettext-parser

Parse and compile gettext po and mo files, nothing more, nothing less
MIT License
160 stars 44 forks source link

Migrate to streamx #63

Closed perrin4869 closed 2 years ago

perrin4869 commented 2 years ago

The main motivation behind this PR is that readable-stream is difficult for bundlers to handle due to circular dependencies (see https://github.com/nodejs/readable-stream/issues/348). I believe this might be the cause behind the discussion here: https://github.com/i18next/i18next-gettext-converter/issues/105 Other than that, streamx seems to have a smaller footprint and other projects like gulp plan to migrate to streamx as well. For your consideration :) Thanks!

smhg commented 2 years ago

@perrin4869 can you have a look at this again please? The readable-stream dependency got an update. Does it still suffer from the same issues?

perrin4869 commented 2 years ago

That's right, readable-stream@4 did indeed solve the issue! I think this change could get some consideration regardless but I will close this since my main motivation is gone. Thanks for the update!

smhg commented 2 years ago

Thank you for the follow up!

perrin4869 commented 2 years ago

gettext-parser@6 seems to not have made it to npm yet :)

smhg commented 2 years ago

@perrin4869 done. Thanks for noticing!