Closed elitenas closed 2 years ago
@thank you for your contribution!
I think it can be merged if you can please have a look at these:
npm run lint
and fix anything that comes up.@smhg all done
@sinnstudio-nas thank you! Can you please have a look at why the tests fail?
Fixed
Please put both changes in separate branches and create separate PR's. This makes it possible to see which changes and tests belong to what feature. Especially with the tests that is very important to have some level of stability for the next release. Thank you!
Edit: let me know if you need any help with that as git can be hard.
@smhg all done. Please merge so I can make a pr for the folding changes :)
@sinnstudio-nas thank you for the changes. Tests are failing on Windows now. Can this be connected to this line you took out?
One more question: can you make the tests fixtures for this feature more concise? Please remove most of the double fixture content that is not related to escaping. Those parts that get tested already in other tests. It makes it easier to look at the tests at a later point in time.
@smhg fixed... please try the merge again :)
Thank you! As per my comments: I think the test fixtures can still be significantly shorter. After that, we're good to merge.
@smhg I simplified tests as much as I could
Possibly the Content-Type
header has to stay. Others can be removed I think. Can you give that a try?
@smhg done
@smhg done
The PR looks good now, thank you for your efforts! The test is failing now however. Can you have a look at that still?
I don't have access to my PC for a week due to vacation. I will take a look after. Thanks!
@sinnstudio-nas take your time - there is no deadline in open source ;)
@smhg fixed. Please merge.
Added an option to skip escape newlines and quotes characters functionality.
Use case: We need the string to be exactly the same as what is in our database because when we import it back into our compiler, it can cause issues.