search

smi2 / phpClickHouse

php ClickHouse wrapper
MIT License
750 stars 139 forks source link

Backward compatibility for setTimeout #168

Open wezztt opened 2 years ago

wezztt commented 2 years ago

Hello with 1.4.5 version you've broke backward compatibility for https://github.com/smi2/phpClickHouse/blame/master/src/Client.php#L186

Also please actualize readme examle https://github.com/smi2/phpClickHouse/blame/master/README.md#L66 $db->setTimeout(1.5); // 1 second , support only Int value o_O

Thanks in advance

xtrime-ru commented 2 years ago

Any idea why float was replaced with int? Looks like unnecessary downgrade.

Ive made PR with proper float support: https://github.com/smi2/phpClickHouse/pull/173 And then found 1.4.5 release notes...

isublimity commented 2 years ago

Some problem #152 max_execution_time - is integer in clickhouse source - Seconds

M(Seconds, max_execution_time, 0, "", 0) \

isublimity commented 2 years ago

Only setConnectTimeOut & getConnectTimeOut can be float