smi2 / phpClickHouse

php ClickHouse wrapper
MIT License
741 stars 139 forks source link

Release 1.5.0 introduces BREAKING CHANGES #184

Open Wirone opened 1 year ago

Wirone commented 1 year ago

Version 1.5.0 released yesterday introduced breaking changes and should be released as 2.0.0 ⚠️

For example:

Argument 1 passed to ClickHouseDB\Settings::setReadOnlyUser() must be an instance of ClickHouseDB\mixed, bool given, called in /app/vendor/smi2/phpclickhouse/src/Client.php on line 139

This release contains types introduced in PHP8 while composer.json defines requirement "php": "^7.3|^8.0" and allows installation on PHP7.4 (which we're using).

Please consider cleaning this up 🙂

isublimity commented 1 year ago

Thx for you report! I re-upload 1.5.0 with hot fix

Wirone commented 1 year ago

I believe it wouldn't happen if there was any CI setup. As far as I see there is no Github Actions definition and Travis was run last time 2 years ago. PHPStan's version is prehistoric (current: 1.9.4) and it reports problems even on level 1 (configured in phpstan.neon.dist):

image

When running it on level 7 (like in the readme), it returns 366 errors... You really need apply some hygiene here, because it really looks unstable 🙁

Wirone commented 1 year ago

@isublimity friendly reminder, because I see updated tag wasn't released.

Wirone commented 1 year ago

@isublimity it's been 4 months now... Please, fix this or just let us know you won't do it.