search

smi2 / phpClickHouse

php ClickHouse wrapper
MIT License
741 stars 139 forks source link

Fixed Issue #206 Php syntax error in php ^7.3 #207

Closed kimpauevg closed 8 months ago

kimpauevg commented 8 months ago

This problem occurs because that syntax is supported only for PHP 8.0 and higher. Using it breaks support for PHP7.

In this pull request, I moved the parameter requirements from attribute definition to phpdoc to fix this problem.

MakarMS commented 8 months ago

Hi, you need to add a typehint for int and remove intval, also edit phpdoc and add a space before the type that the method returns

kimpauevg commented 8 months ago

@MakarMS Hi, done!

isublimity commented 8 months ago

Thx! I`m rollback for support 7.3