search

smi2 / phpClickHouse

php ClickHouse wrapper
MIT License
741 stars 139 forks source link

Do not add unexpected FORMAT JSON for not distributed queries #216

Closed zenoleg closed 2 months ago

zenoleg commented 5 months ago

That changes https://github.com/smi2/phpClickHouse/pull/190 prevent that queries from being executed: CREATE FUNCTION ... or DROP FUNCTION ...

The proposed solution in pull request #214 resolves this specific issue. However, it's essential to acknowledge that this fix might introduce potential compatibility issues with existing codebases.

It seems that the changes made in https://github.com/smi2/phpClickHouse/pull/190 addressed a specific case, but other common scenarios may have been overlooked, so I've implemented an early exit from function when ON CLUSTER does not exist.

zenoleg commented 5 months ago

@isublimity please, check this PR. It seems you are the only maintainer here

isublimity commented 2 months ago

Thx!