search

smikitky / vscode-dicom-dump

A vscode extension that dumps DICOM tags
https://marketplace.visualstudio.com/items?itemName=smikitky.vscode-dicom
MIT License
20 stars 2 forks source link

Private Tag Creator from Dictionary #8

Open cagylogic opened 3 years ago

cagylogic commented 3 years ago

This is not issue. just request.

dicom.showPrivateTags is set true, (odds,00XX) tag is known as Private Creator, VR LO. But still ?? ? = <binary data of length: are displayed.

I understand dicom.dictionary doesn't handle Private Creator. so this is skipped.

extractor.ts line# 149 around. findTagInfo(). add follows to show Private Creator.

if(/[13579bdf]/i.test(tag[4])/*isPrivateTag*/ && tag.substring(5, 7) === '00') { return { name: 'PrivateCreator', vr: 'LO'}; }

smikitky commented 3 years ago

Thank you, I was not aware of this rule, so let me investigate.

Relevant spec: http://dicom.nema.org/medical/dicom/current/output/html/part05.html#sect_7.8

cagylogic commented 3 years ago

I wrote one code to support private tag rule and create Pull request. http://dicom.nema.org/medical/dicom/current/output/html/part05.html#sect_7.8

Please refer it and think to merge or based on that, add that function.

This is my 1st pull request on GitHub. so if I did something wrong, let me know. Thank you.