smilecdr / FHIR.ts

TypeScript/JavaScript FHIR Library
https://www.npmjs.com/package/@smile-cdr/fhirts
Apache License 2.0
40 stars 10 forks source link

Multiple Discrepancies R4 #43

Closed TahaAttari closed 1 year ago

TahaAttari commented 1 year ago
  1. Resource: MessageDefinition.focus.code (code / Required) Resource: CapabilityStatement.rest.resource.type (code / Required) Resource: GraphDefinition.start (code / Required) Resource: GraphDefinition.link.target.type (code / Required) Resource: ImplementationGuide.global.type (code / Required) Resource: SearchParameter.base (code / Required) Resource: SearchParameter.target (code / Required) Resource: Questionnaire.subjectType (code / Required) Resource: OperationDefinition.resource (code / Required) Resource: CompartmentDefinition.resource.code (code / Required) Resource: ExampleScenario.instance.resourceType (code / Required)

Are optional when they should be required

  1. Codes which are part of the ResourceTypes codesystem are left as generic strings when it's a well defined set.
  2. Generic Resource types are used for bundles and other places where Resource is needed, this can be replaced with a union type which supports type inference and narrowing.
TahaAttari commented 1 year ago

fixed