search

smileydts / death-or-glory

0 stars 0 forks source link

Create Rudimentary Main View Page #9

Open djpace14 opened 8 months ago

djpace14 commented 8 months ago

Display your player name at bottom.

Display other players at the table - static icons or layout.

smileydts commented 8 months ago

This is the site I start with whenever I have my first encounter with any new language or popular tool. It has really basic tutorials that help you get your feet wet. They have HTML, CSS, JS, AJAX, etc.

smileydts commented 8 months ago

https://xkcd.com/844/

djpace14 commented 8 months ago

Need to figure out how to make the layout and display adaptive to different screen sizes.

djpace14 commented 7 months ago

I just did a commit and sync with a new index.html on the branch - feature/dog-8-player-id-page

djpace14 commented 7 months ago

I just pushed a commit with the latest version which I think you can merge to the main if you feel it is good.

I changed the text box sizing units - I'm not sure they are perfect but perhaps I bit better.

I also added the cash in, play and discard buttons.

Lastly - I added the function where if you click on each card it enlarges and centers in the screen. And if you click on the card again then it returns to its original position.

Let me know what you think.

smileydts commented 7 months ago

It looks ok aside from that I'm still getting the sizing issue with the text boxes that I had yesterday. As far as clicking on the card goes, what do you think about when you click on a card instead of moving to the center of the screen, it just gets bumped up a little bit? Or becomes highlighted? I think I prefer it when elements don't change position too much when they get clicked.

I resolved the merge conflicts. I'll approve the PR in case you want to merge and work on integrating the APIs, and come back to the visuals later.

On Thu, Feb 1, 2024 at 12:37 PM djpace14 @.***> wrote:

I just pushed a commit with the latest version which I think you can merge to the main if you feel it is good.

I changed the text box sizing units - I'm not sure they are perfect but perhaps I bit better.

I also added the cash in, play and discard buttons.

Lastly - I added the function where if you click on each card it enlarges and centers in the screen. And if you click on the card again then it returns to its original position.

Let me know what you think.

— Reply to this email directly, view it on GitHub https://github.com/smileydts/death-or-glory/issues/9#issuecomment-1921858925, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYAWYG2QTQ77ZDFBWSHOGTYRPHGTAVCNFSM6AAAAABBOXUJNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRHA2TQOJSGU . You are receiving this because you commented.Message ID: @.***>

smileydts commented 7 months ago

Oh yeah our PRs don't need approvals.

On Thu, Feb 1, 2024 at 10:59 PM Dustin Steinhauer @.***> wrote:

It looks ok aside from that I'm still getting the sizing issue with the text boxes that I had yesterday. As far as clicking on the card goes, what do you think about when you click on a card instead of moving to the center of the screen, it just gets bumped up a little bit? Or becomes highlighted? I think I prefer it when elements don't change position too much when they get clicked.

I resolved the merge conflicts. I'll approve the PR in case you want to merge and work on integrating the APIs, and come back to the visuals later.

On Thu, Feb 1, 2024 at 12:37 PM djpace14 @.***> wrote:

I just pushed a commit with the latest version which I think you can merge to the main if you feel it is good.

I changed the text box sizing units - I'm not sure they are perfect but perhaps I bit better.

I also added the cash in, play and discard buttons.

Lastly - I added the function where if you click on each card it enlarges and centers in the screen. And if you click on the card again then it returns to its original position.

Let me know what you think.

— Reply to this email directly, view it on GitHub https://github.com/smileydts/death-or-glory/issues/9#issuecomment-1921858925, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYAWYG2QTQ77ZDFBWSHOGTYRPHGTAVCNFSM6AAAAABBOXUJNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRHA2TQOJSGU . You are receiving this because you commented.Message ID: @.***>