search

smindel / silverstripe-gis

Adds support for geographic types.
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

If silverstripe/postgresql package is not installed, throw meaningful exception #17

Closed phptek closed 5 years ago

phptek commented 5 years ago

At the moment in PostgreSQLSchemaManager:

if (!class_exists(PostgreSQLSchemaManager::class)) {
    return;
}

Consider throwing an Exception "Postgres package not installed"

smindel commented 5 years ago

The above is to drop out of executing the following class definition in situations where Postgres is not installed, so MySQL users don't get a fatal error when compiling the class manifest. The absence of PostgreSQLSchemaManager is not an error, hence no Exception should be thrown.