search

sminez / penrose

A library for writing an X11 tiling window manager
https://sminez.github.io/penrose/
MIT License
1.26k stars 88 forks source link

Example mouse bindings code out of date #305

Closed codybloemhard closed 2 months ago

codybloemhard commented 2 months ago

Describe the bug

I tried out Penrose with the minimal example but it would not compile. Specifically the code that handles the mouse bindings. It cannot find MouseDragHandler, MouseResizeHandler and click_handler. I tried importing them.

The type of the function seems to be wrong as well:

expected struct `std::collections::HashMap<(penrose::core::bindings::MouseEventKind, penrose::core::bindings::MouseState), _>`
               found struct `std::collections::HashMap<penrose::core::bindings::MouseState, _>`

I compile by just giving an empty hashmap as I don't need special mouse bindings.

To Reproduce

Compile the minimal example on the latest version of Penrose.

Expected behavior

Example is expected to compile.

Versions & OS Details

sminez commented 2 months ago

You are compiling examples from the head of develop against the latest release on crates.io which isn't going to work. You can check out the tag for the 0.3.5 release to see the examples that are valid for use with it.

The mouse handlers you are talking about here are not part of 0.3.5 as I've not cut a new release since they were added I'm afraid.