search

sminnee / silverstripe-staticsiteconnector

Connector plugin for the SilverStripe External Content module that uses web scraping to import content.
8 stars 12 forks source link

Can't distribute GPL v2 code (PHPCrawl) #6

Closed chillu closed 11 years ago

chillu commented 11 years ago

From my understanding of the GPL, we can't distribute the PHPCrawl lib with this module (see SO thread). I guess adding it as a composer dependency would be fine, because the user then download himself, right? The lib isn't on composer, but maybe we can change that? (or switch to Goutte hehe)

sminnee commented 11 years ago

PHPCrawl is really good, and I doubt Goutte has the same benefits. It's designed to be a webcrawl, and, for example, supports multi-threaded operation.

We should be able to distribute a GPL module as long as we're clear about the licensing. I'll label this composer package as GPL, and/or include PHPCrawl via composer.

sminnee commented 11 years ago

I set up http://github.com/sminnee/phpcrawl to get the module into packagist, and contained the package maintainer for hopefully a more permanent solution with his blessing.

I'm not sure if "require ../vendor/..." is the best way of referencing regular composer dependencies from SilverStripe code, but it seems to do the trick. The module wasn't really set up to have a functioning autoloader.

chillu commented 11 years ago

composer has a 'classmap' autoloader for this purpose: http://getcomposer.org/doc/04-schema.md#classmap