search

smira / go-statsd

Go statsd client library with zero allocation overhead, great performance and reconnects
MIT License
109 stars 18 forks source link

Add go.mod files #16

Closed vthiery closed 5 years ago

vthiery commented 5 years ago

There is one issue with the call to go get for gometalinter that will modify the go.mod dependency list. Not sure how to proceed with that.

smira commented 5 years ago

Another issue is that all these dependencies are actually only required for the test which benchmarks different implementations, I wonder if I could split it up so that it doesn't get pulled.

I will replace gometalinter with golangci-lint to get more stable and faster linting.

vthiery commented 5 years ago

Another issue is that all these dependencies are actually only required for the test which benchmarks different implementations

That's actually what suggested me to look into the dependencies of go-statsd. I noticed the other statsd clients being pulled when building my project.

I wonder if I could split it up so that it doesn't get pulled.

That would be great, otherwise all the users of go-statsd will be forced to pull them all to build.

smira commented 5 years ago

That's the "feature" of Go which should be addressed with module proxy at 1.13 (?): https://github.com/golang/go/issues/26913#issuecomment-411976222

But I think it makes sense to split out benchmark anyways

smira commented 5 years ago

18 should move out benchmarks, and also creates 'empty' go.mod as it should be

smira commented 5 years ago

Should be resolved with #18, pushed new release 1.3.0 with the changes, I hope this helps.

vthiery commented 5 years ago

Awesome thanks!