smira / go-statsd

Go statsd client library with zero allocation overhead, great performance and reconnects
MIT License
109 stars 18 forks source link

Compatibility with Brubeck #21

Closed forward32 closed 5 years ago

forward32 commented 5 years ago

Hi,

Is go-statsd compatible with brubeck (https://github.com/github/brubeck)? It seems like counters work well, but other types of metrics (gauge, timers) not.

smira commented 5 years ago

Do you have any sample of the request which doesn't work?

go-statsd should emit metrics according to the spec, but there might be some subtle issues.

smira commented 5 years ago

There are some samples in the tests: https://github.com/smira/go-statsd/blob/master/client_test.go#L97

forward32 commented 5 years ago

I suppose that maybe the problem with network on my side. I will check it next week and will be back with results.

Thanks for reply!

forward32 commented 5 years ago

Hi there!

I have tested it again and found problem on my side in the brubeck. This library generates correct outgoing data, so issue is closed now, thanks.