smira / go-statsd

Go statsd client library with zero allocation overhead, great performance and reconnects
MIT License
109 stars 18 forks source link

Metric Prefix should end with a dot by default ? #8

Closed snirad closed 6 years ago

snirad commented 6 years ago

looking at telegraf default config, we can see that he seperate the metric by a dot. if you define a Prefix with go-statsd, you have to add a dot at the end or else telegraf will not move it on.

should we add dot at the end of the prefix by default ?

https://github.com/smira/go-statsd/blob/af08c05945cfe9bd2bdcab186e505df1e439ac7d/options.go#L137

smira commented 6 years ago

@snirad I don't think adding a dot is good as some users might not need it. I think we can make docs more clear by providing example with the dot.

snirad commented 6 years ago

even better