search

smirarab / ASTRAL

Accurate Species TRee ALgorithm
Apache License 2.0
245 stars 69 forks source link

ASTRAL-MP quits when -T 1 #79

Closed ekmolloy closed 2 years ago

ekmolloy commented 2 years ago

Hi Siavash or Chao,

I wanted to run ASTRAL-MP with one CPU thread, and then increasing the number of CPU threads.

The only issue is that ASTRAL-MP this quits for one CPU thread (-T 1). 

Exception in thread "main" java.lang.NullPointerException
    at phylonet.coalescent.Threading.shutdown(Threading.java:33)
    at phylonet.coalescent.CommandLine.main(CommandLine.java:538)

Should I just use ASTRAL-III for the one thread case?

Thanks! Erin

smirarab commented 2 years ago

Two issues. Our error reporting is a bit broken here. I will fix.

ASTRAL-MP is supposed to tell you that:

java.lang.RuntimeException: Sorry, at least two threads are needed. Switch to normal ASTRAL if you have only 1 thread.

If ASTRAL-MP had actually given that error correctly, you would know the answer :)

I don't quite remember why we have this limitation ...

On Fri, Dec 3, 2021 at 1:50 PM Erin Molloy @.***> wrote:

Hi Siavash or Chao,

I wanted to run ASTRAL-MP with one CPU thread, and then increasing the number of CPU threads.

The only issue is that ASTRAL-MP this quits for one CPU thread (-T 1).

Exception in thread "main" java.lang.NullPointerException at phylonet.coalescent.Threading.shutdown(Threading.java:33) at phylonet.coalescent.CommandLine.main(CommandLine.java:538)

Should I just use ASTRAL-III for the one thread case?

Thanks! Erin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/smirarab/ASTRAL/issues/79, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJXOHU27OFZEOF4PCEUNDUPE3STANCNFSM5JKWGHSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Siavash Mirarab

ekmolloy commented 2 years ago

Got it - thank you!