smirarab / ASTRAL

Accurate Species TRee ALgorithm
Apache License 2.0
234 stars 67 forks source link

Final normalized quartet score greater than 1 #91

Open aldendirks opened 11 months ago

aldendirks commented 11 months ago

Hello,

How do I interpret the fact that ASTRAL is reporting a normalized quarter score greater than 1? Here is some of the output from the log:

Using polytree-based weight calculation.
Number of gene trees: 1696
1572 trees have missing taxa
Polytree max score: 2184165598
Polytree building time: 0.502 seconds.
Fail to load native library libAstral.so; use Java default computing method.
Number of quartet trees in the gene trees: 2184165598
Final quartet score is: 2329551031
Final normalized quartet score is: 1.066563374651229
smirarab commented 5 months ago

Hello. I need to investigate this. And somehow I missed this until now. If you still have the file, please send me so that I can see if I can reproduce it and debug.

If your input is multi-individual, ASTRAL first reports a wrong normalized quartet score and then outputs the correct one further down the log file. I thought we do say (potentially wrong) or something like that for the wrong one. But it doesn't appear this way in your file. Please share and I will see if I can fix this. You can email me directly your files if you don't want to share here.