smirarab / pasta

PASTA (Practical Alignment using SATe and Transitivity)
GNU General Public License v3.0
83 stars 25 forks source link

Adapt Pasta to the current version of DendroPy #67

Open simeonborko opened 6 months ago

simeonborko commented 6 months ago

Pasta is compatible with Dendropy <= 4.5.2. I observed these incompatibilities:

This is what I just observed, there may be more work. But wait for the next release of DendroPy, because the last release v4.6.1 is from June 9, 2023, but the master branch has new changes (for example fixes missing @classmethod annotation).

smirarab commented 5 months ago

1fa5fa82db6ee97e8a681a8d32e5c3b5c1a1116 should fix the first issue for now (version 1.9.1) and it worked just fine for me. Will see what other challenges arise. Keeping this open to document new changes needed.