search

smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
49 stars 10 forks source link

Info #16

Closed Acidzero2020 closed 9 months ago

Acidzero2020 commented 9 months ago

Hello, thank you very much for the work.

Do you know if it is possible to get the timestamp of the intros? In the original app you can press skipp intro, but I didn't see any information about the intro in the api.

GajoOptimus commented 9 months ago

I was about to say the same thingšŸ¤£

smirgol commented 9 months ago

Skipping intros is considered a crime. :D Hm no idea, I didn't see anything that could be used, but I'll have another look. How to implement that, if there is an appropriate timestamp info, is another thing.

GajoOptimus commented 9 months ago

Skipping intros is considered a crime. :D Hm no idea, I didn't see anything that could be used, but I'll have another look. How to implement that, if there is an appropriate timestamp info, is another thing.

When all episodes have the same opening...... No problem hahaha

My friend os the One who adds the timestamp when timming the substitles, so the info is there.

smirgol commented 9 months ago

I had a quick look and I have figured out how to get the required timestamps. But adding the skip button is much more complex, as, as far as I can see, it is not a Kodi feature and needs to be added manually using GUI stuff, which I have to read up on first.

Acidzero2020 commented 9 months ago

great, you can do something like this, for example:

https://github.com/Sandmann79/xbmc/blob/383eb90c63a2c5cef254e08c11479345f33cd078/plugin.video.amazon-test/resources/lib/playback.py#L412-L428

https://github.com/CastagnaIT/plugin.video.netflix/blob/1b7dc6fe5166a0ddc5d86f835d33fa4d44d35b7c/resources/lib/services/playback/am_section_skipping.py#L61-L73

smirgol commented 9 months ago

Thanks. I already had a quick look at the Netflix addon yesterday, when I realized I need to take some more time to dig into how exactly it is done.

I'm already on it, but no ETA yet. It requires quite some rewrite to the playback stuff to handle this properly, that takes some time. :)

wweich commented 9 months ago

Another, simpler way would be to set chapters for before and after the intro/outro. The "arrow up" key will jump to the next chapter.

smirgol commented 9 months ago

That would have been an idea as well. But I already mostly finished it. I just need to do some cleanup before I can push it to the staging branches. :)

Acidzero2020 commented 9 months ago

Chapter would be very nice, but how you do it ?

smirgol commented 9 months ago

Skip intro is now live in the staging branches for matrix + nexus. Please let me know if you encounter any issues.

There are also two other changes (new settings page and new resume watching menu item) and changes were made to the settings, so after installing you might need a reboot of kodi.

smirgol commented 9 months ago

I've also added it for the credits as of today. But be aware that sometimes the info isn't there, like for example with Attack on Titan Season 2. I've again re-organized the settings, to move the growing playback settings to a new tab.