refactor: The same code, three times, it's a lot!

[lumiru]

• I found three times the same loop to add episodes from api to current shown directory. So I move it to a single function called add_items_to_view from controller.py to utils.py.
• Renamed get_series_data_from_series_ids to get_data_from_object_ids since this endpoint is not series specific.
• Removed "panel" reference from ObjectData classes since panel is not provided for some endpoints (e.g. the one called by get_data_from_object_ids). The "playhead" is refilled later by wrapping function.
• Always create ObjectData from a wrapping function (get_object_data_from_dict or get_raw_panel_from_dict) to encourage homogeneous behaviours.
• Extract media_info creation from ObjectData in a specific function called create_media_info_from_objects_data to permit usage of its info outside of a shown XBMC list item.

[smirgol]

lolwut? Maybe a title what it actually does or some description would help. ;-D I'll read through that tomorrow.

[lumiru]

lolwut? Maybe a title what it actually does or some description would help. ;-D I'll read through that tomorrow.

I add explanations. The main purpose is the first bullet point, the next ones are mainly splitted functions to encourage homogeneous behaviour.

[smirgol]

Thank you! So much easier to understand what it is supposed to do without studying the (large amount) of changes. :)

The reason for the code duplication is that these parts in the version for the old api were very different in what data they have put into the list. I improved on that a lot by using the DTOs already, but didn't find the time yet to make things even more nicer. So that's a good idea to do it, while it's not an easy task - pagination, callbacks, ... :)

[smirgol]

Looks good to me so far.

I've cleaned it up, fixed the return types and commented out the args.thumb and args.fanart in controller.py, as we no longer have those in the args as of #21