smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
49 stars 10 forks source link

no info for seasons #28

Closed Acidzero2020 closed 9 months ago

Acidzero2020 commented 9 months ago

For the newest master "nexus-staging" branch, I don't have a poster or plot for the seasons anymore. I think you call the site collection_view.

I know that's just the series info, not the seasons.

I don't know if it's just me, but when I open a series with many episodes (e.g. OP), it takes longer than with the old version.

smirgol commented 9 months ago

Yeah, it's...complicated :)

There were quite some changes to how things work under the hood and they are not optimal yet. I was hoping to get in in a better shape more quickly, but it turned out to be pretty complicated and a lot of work. I'm already thinking about rolling it back and resolve it first before merging it back to staging, as my holidays are soon over, which means things will have to slow down and it will take me even longer to resolve everything.

It doesn't really resolve the issue with the plot and the image, as, while they were there, they were just the plot and the image of the parent item - if you are in your playlist and then select "Goto Seasons" for one of the items, on the seasons page it will always show the plot and the description of the current episode in your playlist. A season in itself neither has its own image nor a plot description. But you already noticed that. :)

Then, it's probably a bit slower because it is now loading additional images in a separate call, that are not included in the regular requests that are made to display things. It shouldn't be much slower, maybe a second or something like that. I already thought about caching the images, but that would take up disk space and I don't know if it is much faster when checking and loading like 200 images, as it would have to for my queue view for example.

smirgol commented 9 months ago

I've rolled the changes back, it should behave like before, plus a few minor changes to how things are displayed. Let me know if it is better now, please.

About the additional images, which I think are nice to have: I'll add an option for that to the settings, so one can chose if he wants to load them or not.

Acidzero2020 commented 9 months ago

Thanks for the quick reply. Unfortunately I don't have time to test it until the weekend.

smirgol commented 9 months ago

No problem, take your time. :)

smirgol commented 9 months ago

With the next update I'm pushing today they will be gone again. It really is unfortunate, that Crunchyroll provides no description nor images for seasons at all, at least I was unable to find some. Using the plot of an episode, while it displays something, is not really a good solution. What I can do is at least provide images picked from the overall series.

smirgol commented 9 months ago

New updates are pushed to staging. I've added the series image to the seasons listing, so there is at least something. But it slows down showing the list a bit, as the additional data has to be fetched.

Acidzero2020 commented 9 months ago

Thank you it looks good