search

smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
51 stars 11 forks source link

watched status not set when skipping outro #50

Closed Yavos closed 8 months ago

Yavos commented 8 months ago

If you skip the outro of a show without preview the watched progress still remains at the start of the outro, The skip function should probably include an update call to the progress (to seek_time).

example: https://www.crunchyroll.com/de/watch/GVWU05GD2/perfect-match

smirgol commented 8 months ago

Interesting. I always thought that in theory it should be a problem, but for me, after watching many episodes, it never turned out to be an actual issue. But, I usually only watch full-length episodes, so this probably indeed is an issue with shorter episodes. I'll look into this, thank you for reporting.

smirgol commented 8 months ago

Should be fixed, please let me know if it works for you

Yavos commented 8 months ago

It worked for the episode I just watched. I'll do a bit more testing tomorrow and then close the issue if it keeps working.

Yavos commented 8 months ago

I just noticed the sync_playtime setting isn't used anywhere. Should I open a new issue for that?

smirgol commented 8 months ago

That's interesting, it used to be there - I think :D I'll fix that, no need to create a new issue, thank you.

Yavos commented 8 months ago

So far it works perfectly with commit d447a38. I consider this issue fixed.