search

smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
49 stars 10 forks source link

Option to use short titles in episodes lists #59

Closed xinxs closed 4 months ago

xinxs commented 5 months ago

Hello, There's a thing that I do every new release, is to change how the addon display the episodes titles, because its shows like "(Anime title) (epnumber) (ep title)". Its annoys me, because I already got into the anime folder > season folder, so I know whats the anime name, sometimes with big titles you need to wait the name scrool to found the episode number and title. Captura de tela 2024-04-09 130052

So I though thats would be nice to add an option to use short titles: Captura de tela 2024-04-09 130144

If you use the resume folder its become a mess with list view, but its okay with another views like infowall ss3

Also works "well" with others skins, in the embuary the episode number repeats because how the skin shows titles, but I think is better than the long title starting with the anime name ss4

And I added some missings thing in the pt-br language file. Fell free to add this option or not. Sorry if a did a mess to read the settings in model.py, Im not familiar with py or kodi addons progamming.

smirgol commented 5 months ago

Thank you for your contribution. Yeah it's a mess these days. If the japanese would stop naming their animes like "That homeless random guy that got reincarnated in another world to defeat the demon lord and his mighty mom", that'd help :D

I admit that on some views it's not necessary to prepend the anime name to the title, but on things like the watchlist I'd be totally lost without. I'm using the "list right" view most of the times and we didn't used to have background art for the animes, so without the anime title it's super hard to tell what it is.

I'll look into your PR closer when I find the time, maybe I can also come up with a solution to more flexible titles, depending on the view.

Cheers!

smirgol commented 5 months ago

I've implemented a solution for the episodes view that will use your logic to show a two-digits episode number, followed by the episode title only. I don't think we necessarily need an option for that, as applying this to the episode view should be sufficient. What's your opinion on that? Here's my take on that: https://github.com/smirgol/plugin.video.crunchyroll/commit/a9d4cb7291e58a27f41d48a665d7dad6d3e6b0d4

I've also merged your translation changes, thank you for that!

I'd merge the changes I've made in a few, after some more other changes and close this PR, if that's cool with you. :)

xinxs commented 5 months ago

Sounds great for me. Thanks for taking a time to look this little issue.

smirgol commented 4 months ago

Closed as feature is implemented. Thank you for contributing!