search

smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
49 stars 10 forks source link

Repository ? #6

Closed rjousse18 closed 9 months ago

rjousse18 commented 9 months ago

Given how this application is progressing, would it be possible to make a repository? It would be more practical for those who want to test / use the application.

rjousse18 commented 9 months ago

Since the original developer of the crunchyroll addon no longer maintains it, I think it might be a good option to use your project as a new "unofficial official crunchyroll addon".

GajoOptimus commented 9 months ago

I think the same. I now had the time to check the progress and damn......... Just some errors that a don't even know what they were but its still working fine. What a great work in a tiny little time. Congrats @smirgol

Ps. Automatic updates would be nice hahaha

smirgol commented 9 months ago

I'm not sure about that. My intention was to get it back to a solid working state and have @MrKrabat merge it back into his repository, hopefully. It wasn't my intention to take over the plugin, but to fix it, as for one I thought MrKrabat might not have much time right now to fix it quickly and I really really needed my daily dose of anime again. :o)

So, since I'm a programmer anyway, I thought I might give it a try to fix it. And with the help of https://github.com/stefanodvx/crunpyroll and https://github.com/hyugogirubato/API-Crunchyroll-Beta I had something I could start with - without those, especially the work of @stefanodvx, I couldn't have done it. Big thanks to you guys!

The rest was try and error, reading docs, poking at APIs and a lot of patience plus free time. :)

stefanodvx commented 9 months ago

@smirgol I really appreciate you mentioning me. Thank you so much. I also want to reiterate that I will soon continue the library, which has unfortunately been abandoned for months.

smirgol commented 9 months ago

@stefanodvx Your library was super helpful and I hope you don't mind that I've copied good parts of the session handling from you. Without that I couldn't have done it in a timely manner.

I really like how you wrap all the data into objects, that keeps it really clean and makes accessing (even nested) data easy. :) I've tried to copy that behaviour for handling the difference between Movies and Episodes so I don't have to deep-dive into the API data structure to fetch nested things, but somehow that does not work on Kodi like it does in your library - I assume there is some magic on the Object class that does work on newer python versions only? But then, I actually have no real clue about Python. I'm just curious.

Galnart commented 9 months ago

I thought it was strange that you still had mrkrabat as the author on the plugin and just increased the version number. Didn't know that you just wanted him to merge the changes.

rjousse18 commented 9 months ago

the real problem is that MrKrabat is not maintaining this add-on anymore (see here) unless for the new versions of kodi. That's why I thought it could be great to have a new repo with the work of @smirgol.

smirgol commented 9 months ago

Hm I see. I've read that as well and I understood it the way that when the new API comes out, he might continue his work.

I'm okay with maintaining the addon for a while, although I don't always have that much free time as I have right now, but I should be able to keep it working for a while. Thing is, it was not my intention to silently take over @MrKrabat's work, just help with fixing. I'd like to hear his opinion on that, before I put my name on it and take over the addon, since it's mostly his work, for which I'm really thankful. :)