Version multiprofile don't work

gigoro33 commented 7 months ago

Excuse my English.

The addon don't work with multiprofile

SO: Debian Bookworm Kodi version: kodi 21 Nexus Addon Version: 3.3.0.16 The add-on doesn't work with multiple profiles.

OS: Debian Bookworm Kodi version: Kodi 21 Nexus Add-on Version: 3.3.0.16

Steps to reproduce:

Install the new version.
Open the add-on.

Possible Solution:

To resolve this error, modify line 188 in the file resource/lib/utils.py as follows:

Change:

return path + image

TO: return str(path) + str(image)

PD:

The first time you set the profile, it already works with the old version.

LOG:

EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS! Error Type: <class 'TypeError'> Error Contents: can only concatenate str (not "NoneType") to str Traceback (most recent call last): File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/default.py", line 36, in
crunchyroll.main(sys.argv) File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/resources/lib/crunchyroll.py", line 96, in main controller.show_profiles(args, api) File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/resources/lib/controller.py", line 49, in show_profiles profile_list_items = list(map(lambda profile: ProfileData(profile, args).to_item(args), profiles)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/resources/lib/controller.py", line 49, in
profile_list_items = list(map(lambda profile: ProfileData(profile, args).to_item(args), profiles)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/resources/lib/model.py", line 623, in to_item 'fanart': utils.get_img_from_static(self.wallpaper, "wallpaper"), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/kevins/.kodi/addons/plugin.video.crunchyroll/resources/lib/utils.py", line 185, in get_img_from_static
```
                                               TypeError: can only concatenate str (not "NoneType") to str
                                               -->End of Python script error report<--
```

smirgol commented 7 months ago

Hm that's really interesting, wondering what the underlying issue is. It fetched the data from the API, which includes the wallpaper. So the data should not be None at this point. I've added a None check for the image, but I really would love to understand why it happens in the first place. :-/

xtero commented 6 months ago

On the main profile, it looks like if we don't set the wallpaper, the field does not exist. At least, I had the issue on my own account.

rjousse18 commented 6 months ago

We will probably delete wallpaper feature as it's not really useful, as it's discussed here

smirgol commented 6 months ago

should be fixed with the None check I've added.

smirgol / plugin.video.crunchyroll

Version multiprofile don't work #65