search

smirgol / plugin.video.crunchyroll

Watch videos from the anime platform Crunchyroll.com on Kodi
GNU Affero General Public License v3.0
51 stars 11 forks source link

Optimize Play stream #88

Closed Acidzero2020 closed 1 week ago

Acidzero2020 commented 2 weeks ago

Hello,

here some changes/fixup for the plugin.

commit 1 Should fixes the problem with the manifest https://github.com/smirgol/plugin.video.crunchyroll/issues/71. Stream is cleared before it is fully opened.

commit 2 delete play fallback. I think there are no longer streams without DRM.

commit 3 delete playlist on error to many streams => the other streams won't work either.

smirgol commented 2 weeks ago

Thank you for your contribution, I'm gonna give it a whirl and check it out :)

I'm a bit sad about the removed threads ;) but I agree that you actually don't need them as things can be done within the loop - it's one of these things you add before you realize that you have to keep the player active in a while loop later anyway, making them obsolete, as you could have done that in the loop anyway. But I have to admit that I didn't realize that until now. :)

I find it interesting that this new approach would eliminate the manifest issue. The strange thing about this issue is, that only a reboot fixes it. It suddenly appears for no reason after things worked just fine before and then only goes away with a reboot. What is the actual change you have made that prevents that? I'm curious. :)

smirgol commented 1 week ago

I've merged it as I finally encountered the issue again. It did not fix the issue, but it might have been a new issue. This time the logs were showing up some ssl verify peer error - I've added a new commit to disable that and now it works. Again, not sure if it's the same issue or if it's a new one. Gonna test your changes now, but I think everything's cool.

Thank you for your contribution! :)

smirgol commented 18 hours ago

Unfortunately I still encounter the "can't play" issue, along with that "SSL Could not verify peer" message. Still not sure if it's a new error or if it is the old one, but the logging got better and finally tells the issue. The new option to disable SSL certificate check on curl unfortunately does not work on Matrix, which I'm still on, but for Omega I hope it finally got resolved one way or the other.

Anyway, so far your changes work fine, gonna merge them to main soon.