search

smitelli / cosmore

A reconstruction of the source code of Cosmo's Cosmic Adventure.
https://www.scottsmitelli.com/projects/cosmore
Other
113 stars 6 forks source link

Explain how the parallax scrolling works #7

Closed lethal-guitar closed 2 years ago

lethal-guitar commented 2 years ago

As a follow-up to #6, this adds comments to InitializeBackdropTable, LoadBackdropData, and DrawMapRegion, and renames a few variables.

Also adds an almost novel-sized comment describing the entire parallax scrolling system in detail, as well as an AUTHORS.md file as you suggested in #6.

Let me know what you think - since the explanation is so lengthy, I wasn't sure if you'd maybe prefer to have it outside of the code in a dedicated file, or if you think it's fine like this.

smitelli commented 2 years ago

Looking good! :+1: I saw you pushed recently; let me know when you're ready for the final review and I'll merge then.

As for the lengthiness of the comments, not a problem here -- look at lowlevel.asm for example. :grin: Eventually, I might incorporate/move some of the commentary from here to Cosmodoc, my other perpetually unfinished project. If that happens, I'll be sure to acknowledge your work accordingly.

lethal-guitar commented 2 years ago

Looking good! 👍 I saw you pushed recently; let me know when you're ready for the final review and I'll merge then.

Yeah I had noticed a few small mistakes when re-reading the comments and fixed those. But it should be ready now!

As for the lengthiness of the comments, not a problem here -- look at lowlevel.asm for example. 😁 Eventually, I might incorporate/move some of the commentary from here to Cosmodoc, my other perpetually unfinished project. If that happens, I'll be sure to acknowledge your work accordingly.

Great, sounds good! 👍🏻

smitelli commented 2 years ago

Many, many thanks for your efforts!

lethal-guitar commented 2 years ago

@smitelli it's my pleasure! 🙂 Thanks for making Cosmore, it inspired me to attempt doing something similar for Duke Nukem II. Sort of as a complement to RigelEngine, since its code is extremely different from what the original might have looked like in many aspects, even if the resulting behavior is the same. It's still in the early stages right now, but Cosmore definitely was a great help in getting it off the ground!