search

smith-chem-wisc / FlashLFQ

Ultra-fast label-free quantification algorithm for mass-spectrometry proteomics
GNU Lesser General Public License v3.0
19 stars 15 forks source link

update to Net6 and mzlib 528 #110

Closed trishorts closed 2 years ago

trishorts commented 2 years ago

AC recently updated mzLib to .Net 6.0. .Net 5.0 will no longer be supported. this pull request updates flashlfq to target .net 6.0 and also gets it updated with the current mzlib release 528

trishorts commented 2 years ago

I do not know how to update appveyor to target .net 6.0 so this won't build

trishorts commented 2 years ago

i think i figured it out. we'll see

trishorts commented 2 years ago

can't figure out how to target the docker to .net 6

acesnik commented 2 years ago

There are two lines with net5.0 in the dockerfile. Just change net5.0 to net6.0 in both places, and that should do it.

trishorts commented 2 years ago

Docker file????

acesnik commented 2 years ago

https://github.com/smith-chem-wisc/FlashLFQ/blob/master/Dockerfile

trishorts commented 2 years ago

https://github.com/smith-chem-wisc/FlashLFQ/blob/master/Dockerfile

i was looking everywhere for those last two. you're a life saver

acesnik commented 2 years ago

Should we leave this to @rmillikin to merge?

trishorts commented 2 years ago

Yep. He will review this weekend

acesnik commented 2 years ago

Nice. It might be interesting to test how much faster .NET6 is than .NET5. They put some work into speeding it up, according to the Microsoft blog.