smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 46 forks source link

Match-between-runs and multiprotease search are not compatible #1034

Open rmillikin opened 6 years ago

rmillikin commented 6 years ago

MBR attempts to map identifications from one run onto peaks in another run. This is incompatible with the multiprotease search because it does not make sense to map IDs from one protease onto another (e.g. gluC peptide IDs onto chymotrypsin peaks). There should probably be one FlashLFQ engine created per protease to match-between-runs between those files, and the results should be combined somehow (??).

rmmiller22 commented 6 years ago

normalization -normalize within proteases will work but but protease data will not be normalzed between the proteases -makes sense because wouldn't compare GluC intensity to Trypsin Intensity

rmmiller22 commented 6 years ago

Have experimental design that has bioteps, tech reps etc for each protease error checking must allow for this

acesnik commented 6 years ago

@rmillikin will your new protein quantification work with multiprotease data once this is resolved? Not that I have an application for that, but I wonder if anyone's ever done that and whether it improves quantification like it does parsimony.

trishorts commented 6 years ago

I would think that this would work fine. Fold change should be preserved irrespective of protease

trishorts commented 6 years ago

Normalization across bioreps at the whole protein level should not be effected by protease

rmillikin commented 6 years ago

Right now, normalization and MBR probably get messed up by multiprotease data. With Rachel's upcoming edit they should both work fine. Comparing protein intensities between a GluC and Trypsin file doesn't make sense for a variety of reasons but GluC vs GluC within a multiprotease dataset will work. Right now it would be buggy and normalization may crash.

acesnik commented 5 years ago

How's this coming along?

acesnik commented 5 years ago

@rmillikin has this been solved?

rmillikin commented 5 years ago

No - still a bug

zrolfs commented 5 years ago

This is the last issue in our 1.0 Milestones!