search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
91 stars 46 forks source link

Added null checks to enable display of XL results #2290

Closed Alexander-Sol closed 1 year ago

Alexander-Sol commented 1 year ago

MetaDraw was crashing when you attempted to view XL results. I added a couple of null checks that resolved the issue (#2289.)

MetaDraw was and continues to crash when attempting to read in the Deadends.tsv output from XLSearchTask. This is due to dead ends being recorded as an unrecognized modification. Should maybe be addressed at some point, but it's outside the scope of this PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2290 (674af88) into master (b0e6988) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   92.01%   92.02%           
=======================================
  Files         135      135           
  Lines       20601    20602    +1     
  Branches     2827     2828    +1     
=======================================
+ Hits        18957    18958    +1     
  Misses       1161     1161           
  Partials      483      483
Impacted Files Coverage Δ
...etaMorpheus/GuiFunctions/MetaDraw/DrawnSequence.cs 99.35% <100.00%> (+<0.01%) :arrow_up:
Alexander-Sol commented 1 year ago

This PR can handle visualization of top-down and conventional bottom-up data w/in MetaDraw.