search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 45 forks source link

Fix string split in glyco protein parsimony #2305

Closed trishorts closed 10 months ago

trishorts commented 10 months ago

Some protein accessions contain hyphens. These unexpected hyphens cause a crash in string.split functions for hyphen. This PR replaces the hyphen with the hashtag eliminating the crash.

codecov[bot] commented 10 months ago

Codecov Report

Merging #2305 (16ee6e7) into master (20713d6) will not change coverage. Report is 1 commits behind head on master. The diff coverage is 95.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2305/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2305 +/- ## ======================================= Coverage 92.15% 92.15% ======================================= Files 135 135 Lines 20644 20644 Branches 2841 2842 +1 ======================================= Hits 19025 19025 Misses 1134 1134 Partials 485 485 ``` | [Files Changed](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/TaskLayer/XLSearchTask/WriteFile.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9YTFNlYXJjaFRhc2svV3JpdGVGaWxlLmNz) | `97.74% <94.44%> (ø)` | | | [...TaskLayer/GlycoSearchTask/GlycoProteinParsimony.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9HbHljb1NlYXJjaFRhc2svR2x5Y29Qcm90ZWluUGFyc2ltb255LmNz) | `76.36% <100.00%> (ø)` | |

:loudspeaker: Have feedback on the report? Share it here.