search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 46 forks source link

Added zPlusOne to custom ion selection #2311

Closed nbollis closed 1 year ago

nbollis commented 1 year ago

Enabled zPlusOne to be selected in the custom fragment ion popup window

One section of FileSpecificParameters was untestable. This method was ensured that all properties within FileSpecificParameters shared a name with a property in CommonParameters. This method was called on gui launch to inform any developers if they changed a name of a property. The method has been removed with a test method performing equivalent features.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2311 (af2b2ae) into master (2bf0ae6) will increase coverage by 0.13%. The diff coverage is 88.88%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2311 +/- ## ========================================== + Coverage 92.33% 92.46% +0.13% ========================================== Files 135 135 Lines 20665 20651 -14 Branches 2842 2836 -6 ========================================== + Hits 19081 19095 +14 + Misses 1099 1079 -20 + Partials 485 477 -8 ``` | [Files Changed](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/TaskLayer/MetaMorpheusTask.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9NZXRhTW9ycGhldXNUYXNrLmNz) | `87.29% <85.71%> (+0.01%)` | :arrow_up: | | [MetaMorpheus/TaskLayer/FileSpecificParameters.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9GaWxlU3BlY2lmaWNQYXJhbWV0ZXJzLmNz) | `100.00% <100.00%> (+28.57%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2311/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)