search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 45 forks source link

Glyco Visualization Crash Fix on ambiguous protein from peptide #2317

Closed nbollis closed 7 months ago

nbollis commented 7 months ago

Fixed an issue where the PsmFromTsv.StartAndEndResidueInProtein was set to "". This caused the DrawnSequence.AnnotateBaseSequence to crash. A simple if statement was enough to circumvent this issue and allow plotting. This issue is caused by the peptide sequence not being unique and could potentially derive from several proteins.

codecov[bot] commented 7 months ago

Codecov Report

Merging #2317 (af57984) into master (944aef9) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2317/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2317 +/- ## ======================================= Coverage 92.67% 92.67% ======================================= Files 135 135 Lines 20982 20987 +5 Branches 2880 2880 ======================================= + Hits 19445 19450 +5 Misses 1063 1063 Partials 474 474 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [...etaMorpheus/GuiFunctions/MetaDraw/DrawnSequence.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2317?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0d1aUZ1bmN0aW9ucy9NZXRhRHJhdy9EcmF3blNlcXVlbmNlLmNz) | `99.36% <100.00%> (+0.01%)` | :arrow_up: |