search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
91 stars 46 forks source link

Eliminate delta score option #2338

Closed trishorts closed 10 months ago

trishorts commented 10 months ago

There is a relatively unknown scoring option in MetaMorpheus that was created by one of our grad students some number of years ago. I don't believe that it is really ever used and it is causing me some headaches in the computation of q-value.

This PR eliminates that feature.

image

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (20da6fc) 92.67% compared to head (17b22c1) 92.63%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2338 +/- ## ========================================== - Coverage 92.67% 92.63% -0.05% ========================================== Files 136 136 Lines 21321 21302 -19 Branches 2930 2924 -6 ========================================== - Hits 19760 19733 -27 - Misses 1081 1095 +14 + Partials 480 474 -6 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/EngineLayer/CommonParameters.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0VuZ2luZUxheWVyL0NvbW1vblBhcmFtZXRlcnMuY3M=) | `95.05% <ø> (-0.11%)` | :arrow_down: | | [...pheus/EngineLayer/FdrAnalysis/FdrAnalysisEngine.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL0VuZ2luZUxheWVyL0ZkckFuYWx5c2lzL0ZkckFuYWx5c2lzRW5naW5lLmNz) | `91.38% <100.00%> (-4.13%)` | :arrow_down: | | [MetaMorpheus/TaskLayer/MetaMorpheusTask.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9NZXRhTW9ycGhldXNUYXNrLmNz) | `87.28% <ø> (-0.02%)` | :arrow_down: |